Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add color field component #627

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Aug 9, 2023

Overview

creating field components for widget panel

What I've done

image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

design link https://www.figma.com/file/W6nDSiCBLubcNeAT6RkOoa/%E2%AD%90%E2%AD%90%E2%AD%90Re%3AEarth-Beta-Design-system?node-id=286%3A7208&mode=dev

@nina992 nina992 requested a review from KaWaite as a code owner August 9, 2023 14:56
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8052804
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e5b9432cb5bc000865140c
😎 Deploy Preview https://deploy-preview-627--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 9, 2023
@github-actions github-actions bot requested a review from pyshx August 9, 2023 15:00
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #627 (8052804) into main (ae83bc0) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   28.22%   28.13%   -0.09%     
==========================================
  Files        1474     1478       +4     
  Lines      160007   160501     +494     
  Branches     3727     3731       +4     
==========================================
  Hits        45155    45155              
- Misses     113696   114190     +494     
  Partials     1156     1156              
Flag Coverage Δ
web 26.13% <0.00%> (-0.11%) ⬇️
web-beta 26.13% <0.00%> (-0.11%) ⬇️
web-classic 26.13% <0.00%> (-0.11%) ⬇️
web-utils 26.13% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/fields/ColorField/hooks.ts 0.00% <0.00%> (ø)
...eb/src/beta/components/fields/ColorField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/fields/ColorField/types.ts 0.00% <0.00%> (ø)
web/src/beta/components/fields/ColorField/utils.ts 0.00% <0.00%> (ø)
web/src/beta/components/fields/TextInput/index.tsx 0.00% <ø> (ø)
web/src/beta/components/fields/Toggle/index.tsx 0.00% <ø> (ø)
web/src/beta/components/fields/index.tsx 0.00% <ø> (ø)
...res/Editor/tabs/publish/Nav/PublishModal/index.tsx 0.00% <0.00%> (ø)
...rc/beta/features/Editor/tabs/widgets/Nav/index.tsx 0.00% <0.00%> (ø)
...tabs/widgets/SidePanel/ContainerSettings/index.tsx 0.00% <0.00%> (ø)
... and 1 more

@nina992 nina992 merged commit 9e895ba into main Aug 23, 2023
16 checks passed
@nina992 nina992 deleted the feat(web)/add-property-field branch August 23, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants